Skip to content

Conversation

@mwoolweaver
Copy link
Contributor

What does this PR aim to accomplish?:

check for = false explicitly instead of != true.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@mwoolweaver mwoolweaver requested a review from a team as a code owner November 6, 2025 16:49

# Try to login again until the session is valid
while [ "${validSession}" != true ] ; do
while [ "${validSession}" = false ] ; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change. validSession is set by Authenticate() which get it from

https://github.com/mwoolweaver/PADD/blob/16423a6b6ada5e2a436d6b1ffdd79f4dd110a14d/padd.sh#L300C5-L300C17

If anything goes wrong, it might contain something unexpected or is empty. Therefore, I would keep this check as it was

@yubiuser
Copy link
Member

yubiuser commented Dec 9, 2025

Pinging @mwoolweaver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants