Harden default Content Security Policy (CSP) #2754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
This PR aims to harden the Content Security Policy (CSP) which ships with Pi-hole by setting the default source to none and explicitly allowing certain directives to be loaded. This is essentially a block-by-default approach.
Relevant GitHub discussion: #2734 (comment)
How does this PR accomplish the above?:
This PR hardens the Content Security Policy (CSP) by setting the default source to none. The current CSP scans as below:
The suggested CSP shows as below from the same scanner:
Link documentation PRs if any are needed to support this PR:
pi-hole/docs#1332
By submitting this pull request, I confirm the following:
git rebase)