Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): Repo Sync schema fixes #STRINGS-1074 #748

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jablan
Copy link
Collaborator

@jablan jablan commented Dec 20, 2024

Hey @horstmannmat, I changed slightly your PR #747 by extracting "Repo Sync Events" to a separate section (IMO it's more RESTful that way and makes future extending of the events API a bit easier).

Would you mind telling me what you think, would that work for you?

cc @theSoenke

@jablan jablan requested a review from theSoenke December 20, 2024 09:08
Copy link
Collaborator

@theSoenke theSoenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. Looks good

@horstmannmat
Copy link
Contributor

Ja, I think it makes sense to me, I was trying to follow the previous patterns, but it looks good :)
TYSM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants