Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): Add missing branch parameter to job comment endpoints #STRINGS-988 #724

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 25 additions & 42 deletions doc/compiled.json
Original file line number Diff line number Diff line change
Expand Up @@ -4848,6 +4848,15 @@
"type": "string"
}
},
"branch": {
"name": "branch",
"in": "query",
"description": "Branch to use",
"schema": {
"type": "string"
},
"example": "my-feature-branch"
},
"page": {
"in": "query",
"name": "page",
Expand Down Expand Up @@ -16903,13 +16912,7 @@
"$ref": "#/components/parameters/per_page"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
}
],
"responses": {
Expand Down Expand Up @@ -17116,13 +17119,7 @@
"$ref": "#/components/parameters/id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
}
],
"responses": {
Expand Down Expand Up @@ -17318,13 +17315,7 @@
"$ref": "#/components/parameters/id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
}
],
"responses": {
Expand Down Expand Up @@ -26846,13 +26837,7 @@
"$ref": "#/components/parameters/id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
}
],
"responses": {
Expand Down Expand Up @@ -26974,6 +26959,11 @@
"description": "Comment message",
"type": "string",
"example": "Some message..."
},
"branch": {
"description": "Branch name for the job",
"type": "string",
"example": "my-feature-branch"
}
}
}
Expand Down Expand Up @@ -27003,13 +26993,7 @@
"$ref": "#/components/parameters/id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
}
],
"responses": {
Expand Down Expand Up @@ -27058,13 +27042,7 @@
"$ref": "#/components/parameters/job_id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
"$ref": "#/components/parameters/branch"
},
{
"description": "Order direction. Can be one of: asc, desc.",
Expand Down Expand Up @@ -27201,6 +27179,11 @@
"description": "Job comment message",
"type": "string",
"example": "Some message..."
},
"branch": {
"description": "Branch name for the job",
"type": "string",
"example": "my-feature-branch"
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions parameters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,13 @@ tag:
required: false
schema:
type: string
branch:
name: branch
in: query
description: Branch to use
schema:
type: string
example: my-feature-branch
page:
in: query
name: page
Expand Down
4 changes: 4 additions & 0 deletions paths/job_comments/create.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,8 @@ requestBody:
description: Job comment message
type: string
example: Some message...
branch:
description: Branch name for the job
type: string
example: my-feature-branch
x-cli-version: '2.5'
7 changes: 1 addition & 6 deletions paths/job_comments/destroy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ parameters:
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/job_id"
- "$ref": "../../parameters.yaml#/id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
responses:
'204':
"$ref": "../../responses.yaml#/204"
Expand Down
7 changes: 1 addition & 6 deletions paths/job_comments/index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@ parameters:
- "$ref": "../../parameters.yaml#/X-PhraseApp-OTP"
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/job_id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
- description: 'Order direction. Can be one of: asc, desc.'
name: order
in: query
Expand Down
7 changes: 1 addition & 6 deletions paths/job_comments/show.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ parameters:
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/job_id"
- "$ref": "../../parameters.yaml#/id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
responses:
'200':
description: OK
Expand Down
4 changes: 4 additions & 0 deletions paths/job_comments/update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,8 @@ requestBody:
description: Comment message
type: string
example: Some message...
branch:
description: Branch name for the job
type: string
example: my-feature-branch
x-cli-version: '2.5'
7 changes: 1 addition & 6 deletions paths/job_locales/destroy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ parameters:
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/job_id"
- "$ref": "../../parameters.yaml#/id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
responses:
'204':
"$ref": "../../responses.yaml#/204"
Expand Down
7 changes: 1 addition & 6 deletions paths/job_locales/index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ parameters:
- "$ref": "../../parameters.yaml#/job_id"
- "$ref": "../../parameters.yaml#/page"
- "$ref": "../../parameters.yaml#/per_page"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
responses:
'200':
description: OK
Expand Down
7 changes: 1 addition & 6 deletions paths/job_locales/show.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ parameters:
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/job_id"
- "$ref": "../../parameters.yaml#/id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- "$ref": "../../parameters.yaml#/branch"
responses:
'200':
description: OK
Expand Down
Loading