Fix too early inference of Encapsed string #3585
Open
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Oct 26, 2024
| @@ -1129,9 +1129,6 @@ private function resolveType(string $exprString, Expr $node): Type | |||
| } | |||
|
|
|||
| $resultType = $this->initializerExprTypeResolver->resolveConcatType($resultType, $partType); | |||
| if (count($resultType->getConstantStrings()) === 0) { | |||
There was a problem hiding this comment.
We will still need to check every part to see if it's a lowercase string.
I'm unsure I should change this to
if (count($resultType->getConstantStrings()) === 0 && $resultType->isLowercaseString()->no()) {
to avoid a similar bug to come back if we introduce another string Accessory.
VincentLanglet
force-pushed
the
bug11852
branch
from
2713ab3
to
4592b99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11852