Merged
Conversation
jaapio
force-pushed
the
prepare-6.x-build
branch
from
d41bffc to
18cc702
Compare
We need to move on.
jaapio
force-pushed
the
prepare-6.x-build
branch
from
18cc702 to
889d86b
Compare
Typed tags are no longer creatable via the create method. The parsing has become to complex to handle per tag. This logic has been moved into factories.
TagWithType need to be created via a factory now.
jaapio
force-pushed
the
prepare-6.x-build
branch
from
c2b348c to
fba45a3
Compare
Contributor
|
@jaapio Is it intended to get these changes in 5.x? Asking because I wonder if in Symfony we should adapt for these changes as a bugfix on all branches supporting 5.x or if that’s for a new feature supporting 6.x. |
Member
Author
|
Whoops, that was wrong. Sorry for that. |
Member
Author
|
I removed all the commits from the 5.x branch. Sorry for this mistake |
Contributor
|
Thank you! I’ll keep you posted if I discover any issues while allowing 6.x in the upcoming Symfony 8.1 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #361, #362