Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertion to error path in streams.c #15027

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add assertion to error path in streams.c #15027

merged 1 commit into from
Jul 19, 2024

Conversation

nielsdos
Copy link
Member

This makes the developer intent clear and should prevent some false reports.
See GH-15026.

@nielsdos nielsdos requested a review from bukka as a code owner July 19, 2024 12:02
@nielsdos
Add assertion to error path in streams.c
ef87d15 
This makes the developer intent clear and should prevent some false
reports.
devnexen
devnexen approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, do not know if worth it for PHP-8.2. Not a fix but..

@nielsdos
Copy link
Member Author

Makes sense, do not know if worth it for PHP-8.2. Not a fix but..

Hm, we typically only merge these things into master, I guess that suffices here too.

@nielsdos nielsdos merged commit d75abdc into php:master Jul 19, 2024
10 of 11 checks passed
@cmb69 cmb69 mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @devnexen