Use correct value for PECL DS MIN_CAPACITY constants
#5082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9 years ago (back in the PHP 5.5 days), the PECL
dscodebase was updated to use 8 as minimal size of various vector and hash table implementations as part of the PECL DS 1.2.0 release (released August 3rd, 2017). The PHP documentation was never updated though.This PR updates the documentation values to all reflect the correct
MIN_CAPACITYconstant value for the various PECL DS classes. This PR also adds this to the changelog entries, for sake of completeness.See:
And a few of the specific commits:
The following code verifies that all default/minimal capacities in the various DS classes are indeed set to 8:
Expected output (on any PECL version >=1.2.0 and/or PHP >=5.6):
I also checked the documentation for the other DS classes, those al seem to be correct.