ext/bcmath: Correctly modified an existing document

[SakiTakamachi]

Fixed and added exception behavior.
Also added a <literal> tag.

[Girgias]

Considering how often this is repeated I would use XIncludes to avoid the repetition

[SakiTakamachi]

fixed

[Girgias]

@SakiTakamachi I pushed a bunch of wording fixes and docs fixes which are existing issues, as I wanted to check locally that everything renders somewhat as expected.

[ndossche]

Small nits, otherwise ok

[cmb69]

Hmm, the commit breaks configure for me (Windows, libxml2 2.10.3), due to "nested" xincludes. bcdivmod xincludes the error section from bcdiv which in turn xincludes the contents of the bcadd error section. The latter xinclude is not resolved here, so validation complains. I don't know whether that is a libxml2 issue, or Windows related, or whether I'm doing something wrong.

[leonardolara]

The same happens with me (Suse Linux, libxml 2.10.3, PHP 8.4.0). It is not processing nested xincludes. I processed locally repeating the $dom->xinclude(); (lines 780-787 in configure.php) and it builds successfully.
However it does not build in Github.

[cmb69]

Hmm, from https://discourse.gnome.org/t/libxml2-2-11-0-released/15123:

The XInclude engine has been reworked to properly support nested includes.

Confused.

[cmb69]

Indeed, works (for me) with libxml2 2.11.9; is our CI running libxml2 2.11, since the nested includes have been processed properly?

However it does not build in Github.

Well, apparently it does for this repo.

Still, I don't think we can require libxml2 2.11 (even php-src master still supports >= 2.9.4).

[leonardolara]

I meant I could not build the pt_BR repo in Github.
Locally, neither en nor 'pt_BR' build correctly.

I've just downgraded to libxml2 2.9.14 to match the repo config, but I get the same errors.

What we could do is a loop to redo xinclude() until it gets to zero includes in configure.

[alfsb]

Just a heads up. I'm doing a big change on cofigure.php, that touchs XIncludes by xml:ids, and, indirectly, in duplicated IDs. It not handles recursive XInclude as now, but it seems necessary anyways. I will push a new version soon, that will delay (again) it's merging. And try to come up for a solution for recursive XIndludes in the following days.

The looping xinclude() solves it in all languages that normally builds? (I stopped testing doc-it and doc-ro, as they appear to be dead for more than six months).

[leonardolara]

I tried a looping xinclude() that works for almost all languages that are built normally, except for ja, in which case it generates a XPointer issue that didn't exist before. So I gave up for now, it is a little beyond my understanding.

[Girgias]

Still, I don't think we can require libxml2 2.11 (even php-src master still supports >= 2.9.4).

Why could we not? I don't see really an issue with the doc repo requiring a certain version of libxml, they fix (and break) stuff all the time so needing to support a whole range of versions is going to be impossible.

[SakiTakamachi]

By the way, my local version is 2.9.4, but for some reason there are no problems...

[Girgias]

Exactly what I said, the libxml CI and test coverage is quite bad, @nielsdos has reported multiple bugs upstream that broke the test coverage of DOM and related XML extensions when they did some fixes/refactorings.

[cmb69]

@Girgias, libxml2 2.11 is pretty new, so that might break builds for many users. Even Ubuntu 24.04 ships libxml2 2.9.14 by default. And you would have to ask @derickr (or someone else) to update the build machines. Might also be an issue for CHM building.

[Girgias]

It seems the issue is just present in libxml 2.10, if Saki is able to build with 2.9, soooo.

[cmb69]

From #4163 (comment):

I've just downgraded to libxml2 2.9.14 to match the repo config, but I get the same errors.

Apparently, it sometimes works with libxml2 < 2.11, but sometimes it doesn't.

[alfsb]

Apparently, it sometimes works with libxml2 < 2.11, but sometimes it doesn't.

I opened php/doc-base#194 , that patchs part the problem for translations (it's not related with recursive calls, but with failed XIncludes, that exacerbate the problem). It does not include looping over xinclude(), but local tests showed this is viable workaround for where libxml is failing to recurse.

[alfsb]

Included on doc-base PR 194 above both fixes: tor recursive XIncludes (all languages) and failing XIncludes (all translations). Let me know it this fixes the two separate problems one go. @SakiTakamachi @cmb69 @leonardolara