Remove empty xi:fallback from skeletons and docgen #274
+13
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty xi:fallback elements silently swallow XInclude failures. Removing them ensures missing includes surface as errors instead of being ignored. Relates to php#199.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<xi:fallback/>elements from skeleton templates and the docgen script<xi:include>...<xi:fallback/>...</xi:include>blocks to self-closing<xi:include .../>xi:fallbacksilently swallows XInclude failures; removing them ensures missing includes surface as errorsFiles changed
skeletons/classname.xml— 5 occurrences removedskeletons/exceptionname.xml— 4 occurrences removedscripts/docgen/docgen.php— 4 occurrences removed in generated outputRelates to #199 (Remove all mentions of
<xi:fallback>, XML and code)