Skip to content

feat: adding basic Brave search tool and crawler #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

chr-hertel
Copy link
Member

No description provided.

1. **Clock Tool**: [toolbox-clock.php](examples/toolbox-clock.php)
1. **Crawler Tool**: [toolbox-brave.php](examples/toolbox-brave.php)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same file as above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, works best in combination to read a website after having it in the search results

private HttpClientInterface $httpClient,
) {
if (!class_exists(DomCrawler::class)) {
throw new \RuntimeException('The DomCrawler component is not installed. Please install it using "composer require symfony/dom-crawler".');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have an own runtime exception we should use it. Cannot check, I am currently on a phone 📱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh the exception usage is quite inconsistent - will tackle in a follow-up and streamline all places 👍

@chr-hertel chr-hertel merged commit 0d7bac5 into main Apr 25, 2025
7 checks passed
@chr-hertel chr-hertel deleted the feat-brave-crawler-tool branch April 25, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants