refactor: rename Model::version to Model::name #278
Merged
+78
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Apr 13, 2025
|
Just because i was pinged. I think the For me this fits and should make more clear what is meant. So: 👍 - Thanks, also for the info. |
|
Thanks @DZunke for the feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on an integration for Hugging Face and I think
$versionis misleading since this could also use quite different Models of one family.Looking more into the direction of
GenericModelwhat we saw already with #203https://github.com/php-llm/llm-chain/blob/main/src/Bridge/OpenRouter/GenericModel.php
WDYT @OskarStark @DZunke