Add disk storage ability #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
I was not able to use
go-ds-flatfsdue to its filename limitations, it doesn't support theblocksnamespace that ends up being used because that contains a slash:blocks/abc...xyz.Instead I use the go-datastore example datastore that is extremely simple. They warn that it is unsafe but I believe it to be safe for this application because the only namespace used is
blocks/and the datastore keys are not controlled by the user.For my work use case (temporary file storage to get a CAR file output for uploading), using a proper datastore like badger would not be worth it, so I've gone with the example one here.