Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't always load full file into memory #6

Open
makew0rld opened this issue May 30, 2024 · 0 comments · May be fixed by #7
Open

Don't always load full file into memory #6

makew0rld opened this issue May 30, 2024 · 0 comments · May be fixed by #7

Comments

@makew0rld
Copy link
Contributor

Currently, due to the use of MapDatastore, the entire file (io.Reader) passed to .BuildV1 is kept in memory. It would be nice if there was a way to specify that this should not happen. In those cases, I think using go-ds-flatfs as the datastore in a temp dir might be a good alternative, although I haven't tested it.

I might be able to make PR for this in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add disk storage ability starlinglab/go-ipfs-car
1 participant
@makew0rld