New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inconsistent core_component select input class #6048

Merged

SteffenDE merged 1 commit into phoenixframework:main from suciptoid:main

Jan 26, 2025

Contributor

suciptoid commented Jan 12, 2025

Other core component input has class sm:leading-6 and error handling cause select input has different height and error feedback:

Before:

After:


          Update inconsistent core_component select input class

984789f

josevalim approved these changes

View reviewed changes

SteffenDE merged commit 042ce91 into phoenixframework:main

5 checks passed

Contributor

SteffenDE commented Jan 26, 2025

Thank you! 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet