Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-chroma-vector-db-phi-805 #311

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Conversation

ysolanky
Copy link
Contributor

Additions:

This PR introduces the integration of ChromaDB as a vector database within our project. Additionally, it includes a cookbook example to demonstrate its usage.

Copy link
Contributor

@jacobweiss2305 jacobweiss2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 10 to 13
knowledge_base = PDFUrlKnowledgeBase(
urls=["https://phi-public.s3.amazonaws.com/recipes/ThaiRecipes.pdf"],
vector_db=ChromaDb(collection="recipes", persistent_client=True),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think we remove persistent_client from cookbook

@ashpreetbedi ashpreetbedi merged commit 3c0c261 into main Jul 20, 2024
1 check passed
AbhishekRP2002 pushed a commit to AbhishekRP2002/phidata that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants