updated firecrawl tool according to latest firecrawl version #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashpreetbedi
requested changes
Sep 8, 2024
phi/tools/firecrawl.py
Outdated
| @@ -49,16 +50,17 @@ def scrape_website(self, url: str) -> str: | |||
| scrape_result = self.app.scrape_url(url, params=params) | |||
| return json.dumps(scrape_result) | |||
|
|
|||
| def crawl_website(self, url: str, limit: Optional[int] = None) -> str: | |||
| def crawl_website(self, url: str, limit: Optional[int] = None, wait_until_done: Optional[bool] = None) -> str: | |||
There was a problem hiding this comment.
@Ayush0054 this should only be set on init, not on the tool call as this should be determined when initializing the toolkit
Ayush0054
changed the title
Ayush0054
changed the title
|
Closing and reopening on new branch due to too many merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.