fix ollama function call bug #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorrM
suggested changes
Aug 28, 2024
| "function": _function_def, | ||
| } | ||
| ) | ||
| if tool_calls_result.invalid_json_format: |
There was a problem hiding this comment.
The whole scope should be wrapped inside if tool_calls_result.tool_calls is not None:
so it will make sure it is a tool call and it's not a structured_output, then check one of two states:
- Invalid json format but its func call
- Valid function call
else
So if i edit the original code i will make these changes:
- LINE 140:
if tool_calls_result.tool_calls is not None: - LINE 144:
else:
|
@GuanyiLi-Craig there some changes needed |
|
Closing for now. We will need to update this to the Model class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ollama function calling bug.