Pointing Pattern Lab core deps to new and improved forked deps #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from Drupal Pattern Lab community.
|
Very serious thanks for this dude here. |
|
Thanks Evan! |
|
Digging up the chain of composer dependencies for what needs doctrine 1.5 which requires PHP 7.1 which causes builds to fail on PHP 5.6. |
|
Blerp: grandchild dependency. Opened an issue at patternlab-php-core repo: drupal-pattern-lab/patternlab-php-core#13. |
|
Updating in package.json: gets around this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all the Pattern Lab dependencies to the forked variants being maintained by myself and others in the community in the Drupal Pattern Lab org. We'd love some contribution and help over there if any of you have time! I'm happy to get this in to PL Starter and hope to see the tools grow and evolve now that I'm gone from Phase2; good luck!