Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller:
@phase2/outline-controller-resize-controller
#393base: next
Are you sure you want to change the base?
Controller:
@phase2/outline-controller-resize-controller
#393Changes from 6 commits
9392842
18d869a
1a994c8
a6e25a3
b769a0c
29ff7ba
5b3724a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying the options object directly by pushing to breakpoints array can lead to unexpected side effects.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
display: block
directly on the host element may not be appropriate for all components and could override existing styles.Consider using a more flexible approach or documenting this behavior clearly to inform users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debounced function is recreated on every resize event, which negates the purpose of debouncing.
Move the debounced function creation outside of the ResizeObserver callback to ensure it's created only once.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging a warning to the console for a width of 0 may not always indicate an issue, especially for initially hidden elements.
Consider a more robust way to handle or document this scenario to avoid confusion.