Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat/outline-nav-menu #376

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

WIP feat/outline-nav-menu #376

wants to merge 2 commits into from

Conversation

LeeMellon
Copy link

@LeeMellon LeeMellon commented Apr 7, 2023

Description

Still WIP but in a reviewable state

Adds: outline-nav component and sub-components.

Notes:

Can work with:

  1. Pre-formatted data see default export
  2. JSON:API Menu Items Drupal Module see example of data model here at jsonData
  3. Can be slots all the way down. see SlotsTemplate in storybook

To test with JSON API:

  1. Spin up a Drupal demo environment and install the JSON:API Menu Item module

  2. Build your menu in admin/structure/menu/manage/main

Cursor_and_Edit_menu_Main_navigation___Phase2_Drupal_Demo

  1. Spin up an Outline repo and launch storybook.

  2. Verify the JSON API endpoint is working at [docksal evntronment]/jsonapi/menu_items/main (if you're test menu is the main navigation)

5 Use chrome Cross Domain CORS extension to allow fetch test

  1. Paste the endpoint URL into the menuEndpoint in the story and refresh.

Cursor_and_Screen_Shot_2023-04-07_at_14_51_09_PM_png

Cursor_and_Navigation___Outline_Main_Menu_-_Nav_With_Dynamic_Fetch_URL_⋅_Storybook

Still needs:

  1. Styling
  2. QOL updates
  3. Full accessibility testing.
    Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual Testing
  • Automated Testing
  • Accessibility Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

⚠️ No Changeset found

Latest commit: 1b53af3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for outlinejs ready!

Name Link
🔨 Latest commit 1b53af3
🔍 Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/646bafd7dbe30900089601de
😎 Deploy Preview https://deploy-preview-376--outlinejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

socket-security bot commented Apr 7, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] eval +0 bnjmnt4n
@types/[email protected] None +0 types
@types/[email protected] None +0 types

@himerus himerus added For Review An issue awaiting classification. Codebase Update Needed Type: Component Suggestion Use this label for any issue that is a recommendation for a specific type of component. labels May 22, 2023
@glitchgirl glitchgirl marked this pull request as draft February 6, 2024 15:03
@himerus himerus added the Held for Review Held for review. Considered as a Draft/POC. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Review An issue awaiting classification. Held for Review Held for review. Considered as a Draft/POC. Type: Component Suggestion Use this label for any issue that is a recommendation for a specific type of component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants