CI Workflow #2
Merged
CI Workflow #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mposluszny-splunk
commented
Oct 23, 2024
•
mposluszny-splunk
commented
- Introduced CI for soar-asset-mocker
- Linting rules match dev-cicd-tools rules (orghooks couldn't be directly implemented as it would override pyproject.toml, see PAPP-34977)
- Reformatted files according to new rules
- Introduced code coverage reports
mposluszny-splunk
force-pushed
the
workflow_template
branch
from
5f7e457 to
e7bed5e
Compare
ivellios
reviewed
Oct 25, 2024
ivellios
reviewed
Oct 25, 2024
bb-splunk
requested changes
Oct 25, 2024
bb-splunk
reviewed
Oct 25, 2024
mctonderski-splunk
approved these changes
Oct 25, 2024
ivellios
approved these changes
Oct 25, 2024
bb-splunk
reviewed
Oct 25, 2024
bb-splunk
reviewed
Oct 28, 2024
bb-splunk
approved these changes
Oct 28, 2024
Co-authored-by: bb-splunk <[email protected]>
mposluszny-splunk
added a commit
that referenced
this pull request
Dec 18, 2024
* testing workflow * linting fixes * merged linting and testing to one workflow * name refactor, poetry install in testing * poetry lock update * ci, precommit config * poetry run * align with cicd dev * align line length with cicd tools * urllib3 explicitly specified to match SOAR package * coverage as a separate job, markdown output * push, pr only to main * typo artifact pattern fix * .coverage wildcard removal * debug ls * rename report * debug * move .coverage * code cov limit 90% * removed debug ls * Dispute on line length resolved. * fix fetch strings * own linting action * Moved to ruff, enforced stricter rules. Added poetry update to precommit * Update pyproject.toml Co-authored-by: bb-splunk <[email protected]> * type-requests for mypy * removed unused noqa, improved comment styling * Update pyproject.toml Co-authored-by: bb-splunk <[email protected]> * poetry lock update --------- Co-authored-by: bb-splunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.