-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sponsorship payment terms(due date) to be changed #170
Conversation
ed76b8a
to
61f691e
Compare
I like the principle f this, but a couple of notes.
|
|
cb3177b
to
b4d085b
Compare
This looks a lot better, I think. Reading it again and thinking some more, I thought of one more thing. Should we not just get rid of the "5 days" rule as well, and instead just default the due-by date to 5 days before the conference? ISTM if we're making it flexible we should turn as much hard-coding into default-but-changeable instead. In doing this we could say that the due date is mandatory, and just default it to 5 days before, which I think would make the process clearer? Also, should we not make paymentdueby be a |
I've updated paymentdueby to be just a date and be mandatory |
* Add documentation * Default paymentterms to 30 days
I took the liberty to change I also fixed a couple of typos, and updated the documentation for th elatest changes you made (making it mandatory). I changed the at least to me strange combination of "nulls not allowed but blanks allowed" for a date field (what's a blank date?), and set not null on the int field since it's supposed to be mandatory (and was when edited through django, but we want the not null constraint). Added an actual default for the paymentdueby field - you only had it setting the default in the migration, not when actually creating a new level. Oh, and I rebased it on master. Now let's see if I can figure out how to actually update the PR... |
a1a7f41
to
643c414
Compare
Allow the payment terms(days until payment to be paid) set to values other than 30.
Also allow a deadline to be set where payment is due at the deadline(or on the invoice date) after this time.