Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default background color on tracks #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielgustafsson
Copy link
Collaborator

If the user doesn't specify a background color when configuring a track then the generated CSS is incorrect:

  .track-xyz {
    background-color: ;
    color: #000000;
  }

This adds a default color which is the inverse of the default text color to avoid incorrect CSS.

If the user doesn't specify a background color when configuring a
track then the generated CSS is incorrect:

  .track-xyz {
    background-color: ;
    color: #000000;
  }

This adds a default color which is the inverse of the default text
color to avoid incorrect CSS.
@mhagander
Copy link
Member

Since it causes an issue in the templates we should also set blank=False on it I think?

And mind that changes to the model need to be back patched into the migrations. Since this doesn't actually make any database level changes you shouldn't create a new migration, but you should make modifications to the old one so django doesn't complain about them being missing.

@mhagander
Copy link
Member

(also, please rebase on my fix of the tests, so it stops complaining about that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants