Accept new format references on gocardless redirects as well

pgeu · Dec 22, 2024 · 9071599 · 9071599
1 parent 8fa3381
commit 9071599
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/postgresqleu/gocardless/backendviews.py b/postgresqleu/gocardless/backendviews.py
@@ -15,7 +15,10 @@ def connect_to_gocardless(request, paymentmethodid):
     impl = paymentmethod.get_implementation()
 
     if request.method == 'GET' and 'ref' in request.GET:
-        if request.GET['ref'] != str(paymentmethodid):
+        # Reference is <paymentmethod>-<uuid>, so split it
+        if '-' not in request.GET['ref']:
+            return HttpResponse("Invalid reference format")
+        if request.GET['ref'].split('-', 1)[0] != str(paymentmethodid):
             return HttpResponse("Invalid reference")
 
         # Return from authorization, so we should be good to go!