Add RandomHex tests

cmd/coordctl/main.go

@@ -2,26 +2,16 @@
 
 import (
 	"context"
-	"crypto/rand"
-	"encoding/hex"
 	"fmt"
 
 	"github.com/pg-sharding/spqr/pkg/models/topology"
 	protos "github.com/pg-sharding/spqr/pkg/protos"
 	"github.com/pg-sharding/spqr/pkg/spqrlog"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc"
+	"github.com/pg-sharding/spqr/pkg/coord"
 )
 
-// TDB: move to util
-// TODO : unit tests
-func randomHex(n int) (string, error) {
-	bytes := make([]byte, n)
-	if _, err := rand.Read(bytes); err != nil {
-		return "", err
-	}
-	return hex.EncodeToString(bytes), nil
-}
 
 var (
 	coordinatorEndpoint string
@@ -64,7 +54,7 @@
 		}
 
 		if routerID == "" {
-			routerID, err = randomHex(6)
+			routerID, err = coord.RandomHex(6)
 
 			if err != nil {
 				return err
@@ -144,7 +134,7 @@
 		}
 
 		if shardID == "" {
-			shardID, err = randomHex(6)
+			shardID, err = coord.RandomHex(6)
 
 			if err != nil {
 				return err

pkg/coord/utils.go

@@ -0,0 +1,15 @@
+package coord
+
+import (
+	"crypto/rand"
+	"encoding/hex"
+)
+
+
+func RandomHex(n int) (string, error) {
+	bytes := make([]byte, n)
+	if _, err := rand.Read(bytes); err != nil {
+		return "", err
+	}
+	return hex.EncodeToString(bytes), nil
+}

pkg/coord/utils_tests.go

@@ -0,0 +1,21 @@
+package coord_test
+
+import (
+	"testing"
+
+	"github.com/pg-sharding/spqr/pkg/coord"
+)
+
+func TestRandomHex(t *testing.T) {
+	t.Run("Success case", func(t *testing.T) {
+		output, err := coord.RandomHex(16)
+
+		if err != nil {
+			t.Errorf("Expected no error, got %v", err)
+		}
+
+		if len(output) != 32 {
+			t.Errorf("Expected string of length 32, got %v", len(output))
+		}
+	})
+}