Remove Webmention Dependence on Pings #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly saves from webmention to webmention what is going on.
pfefferle
reviewed
Jul 22, 2024
|
@pfefferle Where are we on this one? |
|
|
|
I agree that we should not care about the pingback settings, but why change the |
pfefferle
reviewed
Sep 14, 2024
| $open = false; | ||
| } else { | ||
| // If the webmentions_closed meta ID has a value then consider webmentions to be open. | ||
| $open = get_post_meta( $post->ID, 'webmentions_closed', true ); |
There was a problem hiding this comment.
this is very misleading! we check for webmentions_closed and write it into $open? 😳
There was a problem hiding this comment.
I think the default should be false because we set it only when webmentions are closed?!?
pfefferle
reviewed
Sep 14, 2024
Comment on lines
+565
to
+566
| $open = get_post_meta( $post->ID, 'webmentions_closed', true ); | ||
| $open = empty( $open ) ? true : false; |
There was a problem hiding this comment.
Suggested change
| $open = get_post_meta( $post->ID, 'webmentions_closed', true ); | |
| $open = empty( $open ) ? true : false; | |
| $closed = (int) get_post_meta( $post->ID, 'webmentions_closed', '0' ); | |
| $open = ! (bool) $closed; |
There was a problem hiding this comment.
Isn't WordPress always transforming booleans into integer-strings when using get_post_meta?
true => '1'
false => '0'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes webmention receiving being dependent on pings_open. It does allow for checking the presence of a webmentions_closed meta key to close webmentions. If this approach is validated, will move to figure out a UI for this.
For the sending, it moves from using the pung URLs property within the post object to a new temporary storage that will just store what was sent last time, compare it to what is being send this time, and use that to send deleted webmentions.