Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
resolv-replace
,sockify
monkey patchesTCPSocket#initialize
which causes an error if it is called withconnect_timeout:
.Rather than check only for
resolv-replace
's specific method, we can check if if the method's parameters have changed.This PR builds on #998 and adds the
socksify
gem to the list of gems to smoke test compatibility with.Closes #996
resolv-replace
compatibility test #998 is merged