Skip to content

Commit

Permalink
Add logger as a dependency
Browse files Browse the repository at this point in the history
There was a warning in ruby-head (3.4) that in Ruby 3.5 logger and
ostruct will not be built-in gems, but regular gems.

This change avoids that warning.

Perhaps the ostruct dependency can be ommitted, I found no usages of it
in the source code of dalli.
  • Loading branch information
olleolleolle committed Aug 8, 2024
1 parent 1d4cbfc commit 9eea4f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ gemspec

group :development, :test do
gem 'connection_pool'
gem "ostruct" # Avoids warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0.
gem 'minitest', '~> 5'
gem 'rack', '~> 2.0', '>= 2.2.0'
gem 'rake', '~> 13.0'
Expand Down
2 changes: 2 additions & 0 deletions dalli.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ Gem::Specification.new do |s|
'changelog_uri' => 'https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md',
'rubygems_mfa_required' => 'true'
}

s.add_dependency 'logger'
end

0 comments on commit 9eea4f0

Please sign in to comment.