Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding text, ideas, and some others cool things. :) #2

Merged
merged 5 commits into from
Jun 6, 2019

Conversation

talueses
Copy link
Member

My "dos lochas"...

Copy link
Member

@techfano techfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pienso que habría revisar un poco ciertos puntos y simplificar un poco, también añadir un propósito como organización.

Podríamos revisar también algunas cosas de aquí por si son de utilidad.

https://github.com/colombia-dev/codigo-de-conducta
https://github.com/colombia-dev/state-of-the-union
https://medium.com/colombia-dev
http://www.coljs.org/

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@lupomontero lupomontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por el PR @talueses 🚀 y disculpa por la demora en contestar 🙈

En líneas generales de acuerdo con los cambios 👍

He dejado varias respuestas a los comentarios de @techfano y te he enviado un PR con algunas correcciones menores. talueses#1

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lupomontero
Copy link
Member

Con respecto al comentario de @techfano:

Podríamos revisar también algunas cosas de aquí por si son de utilidad.

https://github.com/colombia-dev/codigo-de-conducta
https://github.com/colombia-dev/state-of-the-union
https://medium.com/colombia-dev
http://www.coljs.org/

Súper buenas referencias. De hecho, por lo pronto me atrevería a proponer (y votar a favor de) que adoptemos el código de conducta. Más adelante podemos ver lo del blog... eso requiere chamba...

Finalmente, con respecto a [coljs.org][http://www.coljs.org/], es algo que sería chévere coordinar con @lima-js (@lizzie136, @wixo, @Xpktro).

revierte cambio en título y descripción de Principios
Copy link
Member

@lupomontero lupomontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Llegado a este punto... LGTM ⭐

@lupomontero lupomontero merged commit cbfb8ad into peru-dev:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants