Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ada_moveit for Articulable Fork #54

Open
wants to merge 59 commits into
base: jjaime2/dynamixel_hw_interface
Choose a base branch
from

Conversation

jjaime2
Copy link
Contributor

@jjaime2 jjaime2 commented Dec 15, 2024

Description

This pull request modifies launch files to adapt to the specified end_effector_tool. This will allow users to specify tools from fork, and articulable_fork. For developers using ADA before the articulable fork hardware is transitioned in, set the tool to fork.

A prerequisite to testing these changes is having your development machine setup according to the Software Installation section of the Articulable Fork Assembly Guide

Related PRs: #52, #53, personalrobotics/ada_feeding#211

Testing procedure

  • To test in simulation, run ros2 launch ada_moveit demo.launch.py sim:=mock end_effector_tool:=<tool> for each <tool> in fork, articulable_fork
    • In RViz2, observe that the appropriate robot description has been loaded visually
    • Within the MotionPlanning window in RViz2, open the PlanningGroup drop-down menu and observe that the available options are ada, articulable_fork, hand, and jaco_arm.
    • Using the ada planning group, set the goal state to random valid, then plan and execute the trajectory and verify that ADA moves to the desired configuration
  • To test on the real hardware, first connect the appropriate hardware to your development machine via USB, e.g. for end_effector_tool = fork only connect the Jaco to your machine, and for end_effector_tool = articulable_fork connect both the Jaco and Articulable Fork to your machine
    • Open a new terminal and run ros2 run forque_sensor_hardware forque_sensor_hardware --ros-args -p host:=ft-sensor-2
    • Open a new terminal and run ros2 launch ada_moveit demo.launch.py sim:=mock end_effector_tool:=<tool> for each <tool> in fork, articulable_fork
    • Activate the necessary controllers (jaco_arm_controller, af_controller) by running
    • Using the ada planning group, adjust the position of the end-effector frame such that all joints of interest will be actuated without colliding with the test environment, then plan and execute the trajectory and verify that ADA moves to the desired configuration

Before opening a pull request

  • pre-commit run --all-files
  • Run your code through pylint. pylint --recursive=y --rcfile=.pylintrc .. All warnings but fixme must be addressed.

Before Merging

  • Squash & Merge

…ld AF controllers, Add Jaco+AF servo controller
@jjaime2 jjaime2 changed the title Parameterize ada_moveit with end_effector_tool Configure ada_moveit with end_effector_tool Jan 13, 2025
@jjaime2 jjaime2 changed the title Configure ada_moveit with end_effector_tool Configure ada_moveit for Articulable Fork Jan 13, 2025
@jjaime2 jjaime2 marked this pull request as ready for review January 15, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant