[IGNORE] Use separate CI pipeline for PRs due to missing CUE token on PRs#88
Conversation
.github/workflows/ci.yml
Outdated
| build: | ||
| name: 'build' | ||
| # CUE Central Registry login does not work on forks because GitHub Secret is not available | ||
| if: ${{ ! github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
yeah but the issue by doing that, is that we don't know anymore if the plugin can be built
There was a problem hiding this comment.
Yes, cuelang or sdk changes could break the build :/
The frontend/JS tests still run.
There was a problem hiding this comment.
Well, we changed the build of the plugin and now the CLI is running the frontend build
There was a problem hiding this comment.
but yes the tests for the frontend are still running that is true
There was a problem hiding this comment.
hm, yes, iirc jest compiles just-in-time, i.e. only files which are required by tests. then we only have type-check left :\
so, what should we do? Is the CUE registry dropping the requirement of needing a token anytime soon?
There was a problem hiding this comment.
we should have an answer this week, but for the moment I have no good solution :(
There was a problem hiding this comment.
or maybe we could cache the cue dependencies? we don't need to download them every time from the central registry. of course this breaks when a fork is updating the dependencies, but I think that won't happen as much
There was a problem hiding this comment.
ah yeah that's an idea that will mitigate the dependency from the Cuelang team decision.
… PRs Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
f7fb434 to
86940c0
Compare
|
I added a separate pipeline for PRs only, which runs the frontend build/test/lint/type-check. Many PRs only update the frontend pieces, and the original pipeline still runs on commits to the main branch. Let's use this workaround and revert once we have a solution for the CUE registry, wdyt @Nexucis? |
|
yeah let's go like that. It will release a bit the pressure on finding a fine solution for cue. |
CUE Central Registry login does not work on forks because GitHub Secret is not available.
cc @AntoineThebaud @Nexucis