Skip to content

[IGNORE] Use separate CI pipeline for PRs due to missing CUE token on PRs#88

Merged
Nexucis merged 1 commit intoperses:mainfrom
andreasgerstmayr:skip-cue-login
Mar 18, 2025
Merged

[IGNORE] Use separate CI pipeline for PRs due to missing CUE token on PRs#88
Nexucis merged 1 commit intoperses:mainfrom
andreasgerstmayr:skip-cue-login

Conversation

@andreasgerstmayr
Copy link
Contributor

CUE Central Registry login does not work on forks because GitHub Secret is not available.

cc @AntoineThebaud @Nexucis

build:
name: 'build'
# CUE Central Registry login does not work on forks because GitHub Secret is not available
if: ${{ ! github.event.pull_request.head.repo.fork }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but the issue by doing that, is that we don't know anymore if the plugin can be built

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, cuelang or sdk changes could break the build :/
The frontend/JS tests still run.

Copy link
Member

@Nexucis Nexucis Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we changed the build of the plugin and now the CLI is running the frontend build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes the tests for the frontend are still running that is true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, yes, iirc jest compiles just-in-time, i.e. only files which are required by tests. then we only have type-check left :\

so, what should we do? Is the CUE registry dropping the requirement of needing a token anytime soon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have an answer this week, but for the moment I have no good solution :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe we could cache the cue dependencies? we don't need to download them every time from the central registry. of course this breaks when a fork is updating the dependencies, but I think that won't happen as much

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah that's an idea that will mitigate the dependency from the Cuelang team decision.

@Nexucis Nexucis mentioned this pull request Mar 18, 2025
… PRs

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr changed the title [IGNORE] Skip cue registry login on forks [IGNORE] Use separate CI pipeline for PRs due to missing CUE token on PRs Mar 18, 2025
@andreasgerstmayr
Copy link
Contributor Author

I added a separate pipeline for PRs only, which runs the frontend build/test/lint/type-check.

Many PRs only update the frontend pieces, and the original pipeline still runs on commits to the main branch. Let's use this workaround and revert once we have a solution for the CUE registry, wdyt @Nexucis?

@Nexucis
Copy link
Member

Nexucis commented Mar 18, 2025

yeah let's go like that. It will release a bit the pressure on finding a fine solution for cue.

@Nexucis Nexucis merged commit 684adeb into perses:main Mar 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants