Skip to content

[ENHANCEMENT] Table: support custom table cell height#84

Merged
andreasgerstmayr merged 3 commits intoperses:mainfrom
andreasgerstmayr:table-height
Mar 31, 2025
Merged

[ENHANCEMENT] Table: support custom table cell height#84
andreasgerstmayr merged 3 commits intoperses:mainfrom
andreasgerstmayr:table-height

Conversation

@andreasgerstmayr
Copy link
Contributor

We already support custom table cell width, this PR adds changing the cell height. This is required when we show panels in table cells.

I also updated the switch component to reflect that the default value is auto (i.e. if value is undefined, the switch should be enabled).

Requires: perses/perses#2762

Screenshots

Default:
Bildschirmfoto vom 2025-03-12 17-01-51

Custom height:
Bildschirmfoto vom 2025-03-12 17-02-09

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr marked this pull request as draft March 18, 2025 13:27
@andreasgerstmayr andreasgerstmayr marked this pull request as ready for review March 31, 2025 12:34
Copy link
Member

@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@andreasgerstmayr andreasgerstmayr merged commit 16d5800 into perses:main Mar 31, 2025
9 checks passed
coleenquadros pushed a commit to coleenquadros/plugins that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants