-
Notifications
You must be signed in to change notification settings - Fork 53
feat: abac e2e #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
35C4n0r
wants to merge
7
commits into
permitio:main
Choose a base branch
from
35C4n0r:feat-e2e-abac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: abac e2e #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemanor
reviewed
Jun 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please attach a loom/screencast of the feature with some edge cases
const name = 'test-tenant-' + randomName('', ''); | ||
refTenantId.current = name; | ||
if (dryRun) { | ||
// eslint-disable-next-line sonarjs/no-duplicate-string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Use any combination from the given comand:
npx tsx ./source/cli.tsx test generate e2e --models=ABAC --models=RBAC --path=zz.json --dry-run --snippet=jest --snippet-path=a.test.js
Combinations used in demo
CLI Command Combinations for Test Generation
1. Original command - Generate E2E tests for both ABAC and RBAC models with Jest snippets (dry run)
npx tsx ./source/cli.tsx test generate e2e --models=ABAC --models=RBAC --path=zz.json --dry-run --snippet=jest --snippet-path=a.test.js
2. ABAC model only - Generate E2E tests for ABAC model with Jest snippets (dry run)
npx tsx ./source/cli.tsx test generate e2e --models=ABAC --path=abac-tests.json --dry-run --snippet=jest --snippet-path=abac.test.js
3. RBAC model only - Generate E2E tests for RBAC model with Jest snippets (dry run)
npx tsx ./source/cli.tsx test generate e2e --models=RBAC --path=rbac-tests.json --dry-run --snippet=jest --snippet-path=rbac.test.js
4. No snippets - Generate only the test configuration without code snippets
npx tsx ./source/cli.tsx test generate e2e --models=ABAC --models=RBAC --path=config-only.json --dry-run
5. Minimal command - Basic test generation without optional parameters
npx tsx ./source/cli.tsx test generate e2e --models=RBAC --models=ABAC
Demo was done on this configuration

https://www.loom.com/share/af278739f61f47aba2e66ecd95180359
Type of Change
Checklist
main
with an appropriate name (e.g.,fix/issue-123
,feature/new-command
)New Command Details (if applicable)
src/commands
directoryAuthProvider
componentapiKey
argumentAdditional Notes
Screenshots/Recordings