Fix symbolic links cleanup when GitHub is down #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to permitio#634 Add cleanup of broken symbolic links when GitHub is down. * **`packages/opal-server/opal_server/git_fetcher.py`** - Add `_cleanup_broken_symlinks` method to clean up broken symbolic links in the `/proc` directory. - Call `_cleanup_broken_symlinks` method in `fetch_and_notify_on_changes` method after a failed fetch attempt. * **`packages/opal-server/opal_server/policy/watcher/task.py`** - Add `_cleanup_broken_symlinks` method to clean up broken symbolic links in the `/proc` directory. - Call `_cleanup_broken_symlinks` method in `trigger` method when GitHub is down.
✅ Deploy Preview for opal-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #634
Add cleanup of broken symbolic links when GitHub is down.
packages/opal-server/opal_server/git_fetcher.py_cleanup_broken_symlinksmethod to clean up broken symbolic links in the/procdirectory._cleanup_broken_symlinksmethod infetch_and_notify_on_changesmethod after a failed fetch attempt.packages/opal-server/opal_server/policy/watcher/task.py_cleanup_broken_symlinksmethod to clean up broken symbolic links in the/procdirectory._cleanup_broken_symlinksmethod intriggermethod when GitHub is down.