Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Blob Storage as a PolicyBundleServerType #532

Closed
wants to merge 3 commits into from

Conversation

devine12
Copy link

@devine12 devine12 commented Jan 4, 2024

Fixes Issue

Fix issue #529

Changes proposed

Ability to connect to Azure Blob Storage as the PolicyBundleServerType.

Ability to generate SAS tokens dynamically via ManagedIdentity.

Add URL encoding to the api_policy_source, fetch_policy_bundle_from_api_source method due to special characters in the SAS tokens required to connect to Azure Blob Storage.

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

…o blob storage as budleserver

Add azure blob dependencies to opal-server requirements

Fix description of account url in docs

Mask the fake app id to lessen confusion in docs

Documentation formatting
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for opal-docs ready!

Name Link
🔨 Latest commit f33a041
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/6597ab4b3485810008354163
😎 Deploy Preview https://deploy-preview-532--opal-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@obsd obsd requested review from orishavit and roekatz and removed request for roekatz January 9, 2024 09:24
Copy link
Contributor

@obsd obsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer such addition to be a community module so that not everyone will need to install the Azure package.

Thanks again for the contribution, and sorry that it took us so much time to answer

@roekatz roekatz closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants