-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-1116 Documented how to define tde_heap as default table access method #328
Conversation
Performance test results:
|
960434b
to
85f9913
Compare
|
||
While the `tde_heap_basic` access method is available with both PostgreSQL Community and Percona Server for PostgreSQL, the `tde_heap` (tech preview) table access method is available only with Percona Server for PostgreSQL. Check how to install it [On Ubuntu](apt.md#__tabbed_2_2) and [on RHEL and derivatives](yum.md#__tabbed_2_2) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to explain how tde_heap works with data? I need your input here, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think it would be helpful to do that, let me get back to you with a graphic that we can add.
9a0c74a
to
5620089
Compare
This PR needs a rebase |
5620089
to
77bf425
Compare
Rebased. I have a pending question in comments. I believe it is useful to explain what happens behind the scenes. I'd like to hear your opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM/ Just a minor suggestion
|
||
The `tde_heap` access method works on top of the default `heap` access method and is a marker to point which tables require encryption. It uses the custom storage manager TDE SMGR, which becomes active only after you installed the `pg_tde` extension. | ||
|
||
When a table requires encryption, every data block is encrypted before it is written to disk and decrypted after reading before it is sent to the PostgreSQL core and then to the client. The encryption is done at the storage manager level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk if it makes sense, but maybe we should clarify that data is decrypted before being sent(written) to Buffer Manager. Because the core (backend) reads data from there (Buffer Manager) in order to send it to a client or perform any other operation.
I think it'll add more understanding for those who more or less familiar with the PG internals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dAdAbird Does Buffer manager participate in encryption process or only in decryption?
Co-authored-by: Andrew Pogrebnoi <[email protected]>
modified: documentation/docs/setup.md
new file: documentation/docs/table-access-method.md
modified: documentation/mkdocs.yml