Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-850 - Update kuttl version to 0.16.0 #799

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

tplavcic
Copy link
Member

@tplavcic tplavcic commented Jun 5, 2024

CLOUD-850 Powered by Pull Request Badge

CHANGE DESCRIPTION

New version of kuttl is out and it has some improvements so it would be good to update it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@tplavcic tplavcic marked this pull request as draft June 5, 2024 12:19
@tplavcic
Copy link
Member Author

tplavcic commented Jun 5, 2024

Some stack traces are thrown by kuttl in each test run, although it doesn't seem to affect the running of the test, but looks a bit bad:

    logger.go:42: 11:25:53 | tablespaces/2-verify-tablespace-volume | + i=4
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 25 [running]:
	>  runtime/debug.Stack()
	>  	/nix/store/khpb8wx5dvf3bshb0iz9dm23z83r6niv-go-1.21.7/share/go/src/runtime/debug/stack.go:24 +0x5e
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	>  	/home/mowsiany/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/log.go:60 +0xcd
	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc0002e5b80, {0x18220c3, 0x14})
	>  	/home/mowsiany/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/deleg.go:147 +0x45
	>  github.com/go-logr/logr.Logger.WithName({{0x1a9af50, 0xc0002e5b80}, 0x0}, {0x18220c3?, 0x0?})
	>  	/home/mowsiany/go/pkg/mod/github.com/go-logr/[email protected]/logr.go:336 +0x3d
	>  sigs.k8s.io/controller-runtime/pkg/client.newClient(0x12fd873?, {0x0, 0xc00041ab60, {0x1a9c4a0, 0xc0002e5100}, 0x0, {0x0, 0x0}, 0x0})
	>  	/home/mowsiany/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/client.go:122 +0xec
	>  sigs.k8s.io/controller-runtime/pkg/client.New(0xc0001538c0?, {0x0, 0xc00041ab60, {0x1a9c4a0, 0xc0002e5100}, 0x0, {0x0, 0x0}, 0x0})
	>  	/home/mowsiany/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/client.go:103 +0x7d
	>  github.com/kudobuilder/kuttl/pkg/test/utils.NewRetryClient(0xc0002de000?, {0x0, 0xc00041ab60, {0x1a9c4a0, 0xc0002e5100}, 0x0, {0x0, 0x0}, 0x0})
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/utils/kubernetes.go:177 +0x125
	>  github.com/kudobuilder/kuttl/pkg/test.(*Harness).Client(0xc0002de000, 0x0?)
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/harness.go:323 +0x194
	>  github.com/kudobuilder/kuttl/pkg/test.(*Step).Create(0xc0000b7ad0, 0xc00050c9c0, {0xc000049c00, 0x1b})
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/step.go:177 +0x63
	>  github.com/kudobuilder/kuttl/pkg/test.(*Step).Run(0xc0000b7ad0, 0xc000501fa0?, {0xc000049c00, 0x1b})
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/step.go:457 +0x25a
	>  github.com/kudobuilder/kuttl/pkg/test.(*Case).Run(0xc0003015e0, 0xc00050c9c0, 0xc000122a80)
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/case.go:362 +0x7f6
	>  github.com/kudobuilder/kuttl/pkg/test.(*Harness).RunTests.func1.1(0xc00050c9c0)
	>  	/home/mowsiany/go/src/github.com/kudobuilder/kuttl/pkg/test/harness.go:401 +0x1cb
	>  testing.tRunner(0xc00050c9c0, 0xc000263518)
	>  	/nix/store/khpb8wx5dvf3bshb0iz9dm23z83r6niv-go-1.21.7/share/go/src/testing/testing.go:1595 +0xff
	>  created by testing.(*T).Run in goroutine 24
	>  	/nix/store/khpb8wx5dvf3bshb0iz9dm23z83r6niv-go-1.21.7/share/go/src/testing/testing.go:1648 +0x3ad
    logger.go:42: 11:25:54 | tablespaces/2-verify-tablespace-volume | test step completed 2-verify-tablespace-volume

@tplavcic
Copy link
Member Author

tplavcic commented Jun 5, 2024

There's a ticket open here: kudobuilder/kuttl#505

@tplavcic tplavcic marked this pull request as ready for review June 6, 2024 07:48
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
demand-backup passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 16 out of 16

commit: 1b5ad49
image: perconalab/percona-postgresql-operator:PR-799-1b5ad49ad

@tplavcic tplavcic merged commit 9d95648 into main Jun 6, 2024
14 checks passed
@tplavcic tplavcic deleted the CLOUD-850-kuttl branch June 6, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants