Allow for a different host #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if `path` begins with "http" or "https" and refrain from preppeding the default host if it does. Changed in order to be able to use the package with Google Spreadsheets API (that uses a different host).
|
Looks like this duplicates #9 but merges better. Don't mind me just a bystander |
|
Could we possibly merge this? Right now this package isn't usable with any of the APIs not hosted at the hardcoded path.... |
|
Alternate hosts is super essential for a lot of the Google APIs, so this really should merge. If you need this asap, I've been maintaining a fork at {sheets} = GoogleApi.get 'v4/spreadsheets/' + docId,
host: 'https://sheets.googleapis.com'
user: Meteor.users.findOne @userId |
|
@danopia would you be interested in becoming a maintainer for this package? We aren't actively using it at the moment, would be good to get someone involved who is using it day to day. |
|
can this be merged please, I want to use google spreadsheets api but cant do it without this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if
pathbegins with "http://" or "https://" and refrain frompreppeding the default host if it does.
Changed in order to be able to use the package with Google Spreadsheets
API (that uses a different host).