Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more meta-commands #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rdunklau
Copy link

I'm not sure this will be accepted because it can modify the behaviour.
However, in certain cases, in can be useful to have those meta-commands in the SQL file and handle them when running the files manually, and drop them if the files are run through django-north.

@rdunklau rdunklau self-assigned this Jul 10, 2020
@k4nar
Copy link
Contributor

k4nar commented Jul 10, 2020

Ideally it would be great if we could execute those instructions instead, to make sure we run the actual DML.

Also we should fix this in https://github.com/peopledoc/septentrion/ instead, as soon django-north will just be a wrapper around it.

@ewjoachim
Copy link
Contributor

I second @k4nar ’s comment.

If I understand correctly, those instructions are understood by psql, so this would mean quite the shift in the way it works: either we’d need to parse them ourselves or we’d need to shift from psycopg2 to psql subprocess.

That being said, it would probably work.

@rdunklau would you mind opening a septentrion issue ? Or I’ll do it.

@ewjoachim
Copy link
Contributor

Ok, I think we'll go the way of peopledoc/septentrion#73

If it's ok with you, @rdunklau, I'll let you close the PR.

Thanks for the contribution though, it's highly appreciated, and started a discussion that will end up improving both projects !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants