-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't retain port in CRSessionClient
, remove singleton pattern
#2018
base: connection-lifecycle-branch
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! went through the CRSessionClient
connection flow and left a comment about addressing listener leaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed base branch to connection-lifecycle-branch
we can think more about handling memory leaks separately in the reconnection PR.
f4befc5
to
4db0248
Compare
4db0248
to
90707e8
Compare
Description of Changes
CRSessionClient
of@penumbra-zone/transport-dom
no longer retains aMessagePort
and no longer uses a singleton pattern.Related Issue
fixes #1736
Checklist Before Requesting Review
Tested in combination with other work, not yet tested alone.