Layout groups + stylings #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is for the landing page and (main) is for everything else.
…nt stylings with mocks and with new layout grouping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #111
This PR adds layout groups to help keep stylings consistent across all major routes.
(index)/page.tsxis the default landing page at/and usesapp/layout.tsxonly. Everything else is under(main)/*which has its ownlayout.tsxthat is used to consolidate the top level styling for the "main" content of each page route.There's a fine line here for what gets abstracted out into its own component (ui or otherwise) because now each route under
(main)/is largely boilerplate for a data prefetch + page title + page table(s). I feel like I could cut out some more boiler plate with the prefetching stuff, at least for tables (#133). Taking it to the next level by factoring out a common component for page title seems excessive and would make things unnecessarily de-coupled... I think.