Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[J-TB] 깃허브 이슈 등록 기능 #1131

Merged
merged 15 commits into from
Jun 25, 2024
Merged

[J-TB] 깃허브 이슈 등록 기능 #1131

merged 15 commits into from
Jun 25, 2024

Conversation

yoouyeon
Copy link
Contributor

관련 이슈

작업 내용

슬랙 알림을 위한 깃허브 이슈 등록 기능 임시로 추가했습니다.
내용 피드백 부탁드립니다...ㅎㅎ

Screen_Shot 2024-06-11 17 43 30

참고

환경변수 추가해주세요!

NEXT_PUBLIC_GITHUB_TOKEN="본인 깃허브 토큰"

@yoouyeon yoouyeon self-assigned this Jun 11, 2024
joonseong11
joonseong11 previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트용 주소일까요? 아하 나의 로컬 작업때 확인해보시라고 만들어둔 것 이군요! 고생하셨습니다!

@yoouyeon yoouyeon marked this pull request as ready for review June 11, 2024 10:34
@yoouyeon yoouyeon requested a review from a team as a code owner June 11, 2024 10:34
@yoouyeon yoouyeon requested review from HiHoi and asroq1 and removed request for a team June 11, 2024 10:34
HiHoi
HiHoi previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. octopi 깃허브를 보니 타입스크립트에서 버전이 올라가거나 octokit 버전이 올라가는 경우 간헐적으로 타입 에러가 나는 거 같습니다. 이 부분만 코드 상단에 적어주시면 좋겠습니다.

그리고 에러가 난 경우 피어 이메일로 로그를 보내주거나 지금 사용하고 있는 와탭 이벤트에 연결해서 로그를 보여주는 방법도 좋아보입니다.

@yoouyeon
Copy link
Contributor Author

@HiHoi

octopi 깃허브를 보니 타입스크립트에서 버전이 올라가거나 octokit 버전이 올라가는 경우 간헐적으로 타입 에러가 나는 거 같습니다. 이 부분만 코드 상단에 적어주시면 좋겠습니다.

이부분 혹시 원문 링크 있으면 알려주실 수 있으신가요??!! 원문까지 같이 주석으로 달고 싶은데 원문을 찾지 못해서요ㅜㅜ

오류 알림 부분은 일단 주석으로만 달아두고 나중에 다시 논의해보는 것이 좋을 것 같아요!!

@HiHoi
Copy link
Contributor

HiHoi commented Jun 18, 2024

@yoouyeon
octokit/octokit.js#2439 : string 타입 오류
octokit/octokit.js#1624 : v17 오류
octokit/octokit.js#2598 : import 에러

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

HiHoi
HiHoi approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다. 수고하셨습니다.

@yoouyeon yoouyeon merged commit bf2ba5d into release-1.0.8 Jun 25, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1130-j-tb-create-github-issue branch June 25, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiHoi HiHoi HiHoi approved these changes

@joonseong11 joonseong11 joonseong11 left review comments

@asroq1 asroq1 Awaiting requested review from asroq1 asroq1 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@yoouyeon yoouyeon

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoouyeon @HiHoi @joonseong11