Only update .pcmanx/pcmanx and .pcmanx/favorites when needed. Fix #86. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is: Always write favorites to the file whenever the program is going to close. To-be: Remove the call of SaveFavorites() on exit. Add a check to compare favorites lists before saving in the callback OnEditFavorites().
As-is: Always write configurations to the file whenever the program is going to close. To-be: Remove the call of AppConfig.Save() on exit. Add checks to configurations before saving.
|
@czchen ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #86.
As-is:
1). Always write configurations to the file whenever the program is going to close.
2). Always write favorites to the file whenever the program is going to close.
To-be:
1). Remove the call of AppConfig.Save() on exit. Add checks to configurations before saving.
2). Remove the call of SaveFavorites() on exit. Add a check to compare favorites lists before saving in the callback OnEditFavorites().