Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Specific Lock Files #25

Merged
merged 23 commits into from
Oct 14, 2024
Merged

Platform Specific Lock Files #25

merged 23 commits into from
Oct 14, 2024

Conversation

mhogan-nwra
Copy link

Platform Specific Lock Files

FollowingIssue #24 , I have updated the project to support the recommended PDM procedure of having different platform-specific lock files.

Following the "Pull Request Guidelines"

Include an example for use

No source code was changed.

Update the author list in AUTHORS.rst if applicable

Not applicable

Ensure that all checks passed (current checks include GitHub Actions)

Not all checks passed on my end. My most recent run encountered a failure with Windows 3.9 due to a TclError. I encountered this error in the envector fork also. My recommended fix for this is to add try-except with any doctest that calls matplotlib or to remove matplotlib in doctests altogether.

pbrod and others added 23 commits October 1, 2024 16:43
 * Simplified pdm_windows.lock
 * Added pdm_linux.lock
 * Added sphinx_build_latexpdf script to pyproject.toml
Change CHANGELOG from restructuredTxt to markdown in order to prepare for automatic updates using git-cliff for semantic versioning.
The `nvector` project now use python-semantic-release for automating its releases
in order to simplify the process.
Move all code related to publishing from python-package.yml to release.yml
Send coverage report to codeclimate, codecov and SonarCloud again as well as test for all python- and os-versions.
Update README.rst and CHANGELOG.md and add pdm.lock and cliff.toml to library.
The short description in the pyproject.toml file indicates this project is a fork of itself, which is inaccurate. The text originates from the "envector" fork.
Insert into the requires-python inequality string not 3.13.*. The CI action failed on 3.13.0 as shown at https://github.com/mhogan-nwra/nvector/actions/runs/11262223929.
Add a PDM script that will generate a macOS lock file consistent with the other platform-specific lock files.
Add the PDM macOS lock file.
Change the python-package.yml workflow to use the platform specific lock files.
For each platform-specific lock file, remove the python version so the ci and coverage jobs do not need to regen them.
@mhogan-nwra
Copy link
Author

The ci checks failed on Windows Python 3.12 and my fork failed on Windows Python 3.9. I think this issue is the result of the Tkinter matplotlib backend. Maybe another different fix is to specify a different backend like agg.

@pbrod pbrod merged commit e760810 into pbrod:develop Oct 14, 2024
12 of 13 checks passed
@pbrod
Copy link
Owner

pbrod commented Oct 14, 2024

Thanks @mhogan-nwra.

@pbrod pbrod mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants