-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform Specific Lock Files #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.0.0
Change CHANGELOG from restructuredTxt to markdown in order to prepare for automatic updates using git-cliff for semantic versioning. The `nvector` project now use python-semantic-release for automating its releases in order to simplify the process.
…m-bump and git-cliff.
…om workflows/python-package.yml
Move all code related to publishing from python-package.yml to release.yml
Send coverage report to codeclimate, codecov and SonarCloud again as well as test for all python- and os-versions.
Update README.rst and CHANGELOG.md and add pdm.lock and cliff.toml to library.
The short description in the pyproject.toml file indicates this project is a fork of itself, which is inaccurate. The text originates from the "envector" fork.
Insert into the requires-python inequality string not 3.13.*. The CI action failed on 3.13.0 as shown at https://github.com/mhogan-nwra/nvector/actions/runs/11262223929.
Add a PDM script that will generate a macOS lock file consistent with the other platform-specific lock files.
Add the PDM macOS lock file.
Change the python-package.yml workflow to use the platform specific lock files.
Fix incorrect syntax of steps with if: CASE
For each platform-specific lock file, remove the python version so the ci and coverage jobs do not need to regen them.
The ci checks failed on Windows Python 3.12 and my fork failed on Windows Python 3.9. I think this issue is the result of the Tkinter matplotlib backend. Maybe another different fix is to specify a different backend like agg. |
Thanks @mhogan-nwra. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform Specific Lock Files
FollowingIssue #24 , I have updated the project to support the recommended PDM procedure of having different platform-specific lock files.
Following the "Pull Request Guidelines"
Include an example for use
No source code was changed.
Update the author list in AUTHORS.rst if applicable
Not applicable
Ensure that all checks passed (current checks include GitHub Actions)
Not all checks passed on my end. My most recent run encountered a failure with Windows 3.9 due to a TclError. I encountered this error in the envector fork also. My recommended fix for this is to add try-except with any doctest that calls matplotlib or to remove matplotlib in doctests altogether.