Do not filter out parameters with the same name in pagination links

[eahlberg]

Fixes #40

[eahlberg]

@pbrisbin feel free to take a look at this when time permits. I also left a few comments above. FYI: I'm on GHC 8.10.7 and couldn't test this using GHC 9.0.2, if this causes any issues I'll try to get 9.0.2 up and running.

[pbrisbin]

This is great, thank you.

[pbrisbin]

Can you go ahead and bump the minor version in package.yaml (and don't forget to also commit the .cabal change that results) and update the CHANGELOG? That way, when I merge this, it'll auto-release to Hackage.

[eahlberg]

@pbrisbin I went with the approach of exporting the parameter filtering function to simplify the spec and left a few comments above regarding things I'm unsure of, it'd be nice if you could take a look.

[pbrisbin]

Thanks for your continued efforts here, I requested some minor changes.

[eahlberg]

@pbrisbin I took another look at this and tried to clean up the conversation above a bit. I couldn't come up with property tests for everything but added a couple of property tests, unit tests and left a few comments. Not sure if the CI failure is related to this.

Feel free to take a look when time permits and let me know if I've missed anything or if you have any questions!

[pbrisbin]

This looks good overall, thanks! There are just a few organizational things I noted, but I'm willing to just fix that up myself and push to this PR before merging, if you prefer. Let me know!

[eahlberg]

@pbrisbin thanks for the feedback, I think all issues should be addressed!

[pbrisbin]

Awesome. I set this to auto-merge on green, which will auto-release to Hackage. Thanks!

[eahlberg]

@pbrisbin there are two CI jobs failing which I'm not sure if they're relevant or not: CI / test (stack.yaml) and restyled. If you have the time to take a look that'd be great.

[pbrisbin]

which I'm not sure if they're relevant or not

Just for future reference: if the PR check is Required, it's, well, required. Otherwise, it's not.

So let's ignore Restyled for now and look at the main test. It looks like a new weeder was released and the latest version doesn't work with current LTS. That project runs ahead and this happens a lot. We just have to tell the action to use a version that works. I think this should do it,

diff --git i/.github/workflows/ci.yml w/.github/workflows/ci.yml
index 95effd4..58b08c8 100644
--- i/.github/workflows/ci.yml
+++ w/.github/workflows/ci.yml
@@ -47,6 +47,8 @@ jobs:

       - if: ${{ matrix.stack-yaml == 'stack.yaml' }}
         uses: freckle/weeder-action@v1
+        with:
+          weeder-version: 2.3.0

   hlint:
     runs-on: ubuntu-latest

[eahlberg]

Missed the Required tag completely in the UI, thanks for clarifying. I updated the Weeder version as you suggested but there were some jobs which immediately failed due to GitHub Actions being unavailable, perhaps you could trigger a re-run when time permits and see if it is back up.

[pbrisbin]

Wow yeah, still down. I'll keep an eye on the status page and re-run when it's back up.