WIP converting all static strings over to draft 2020-12 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmabey
commented
Jan 28, 2025
| @@ -1409,7 +1409,7 @@ std::shared_ptr<schema> schema::make(json &schema, | |||
|
|
|||
| schema.erase(attr); | |||
|
|
|||
| // special case where we break draft-7 and allow overriding of properties when a $ref is used | |||
| // special case where we break draft-7 and allow overriding of properties when a $ref is used <<-- might be out-of-date now that 2020-12 is used | |||
There was a problem hiding this comment.
Can someone help me understand the meaning in this comment?
| @@ -37,7 +37,7 @@ namespace nlohmann | |||
|
|
|||
| // A class representing a JSON-URI for schemas derived from | |||
| // section 8 of JSON Schema: A Media Type for Describing JSON Documents | |||
| // draft-wright-json-schema-00 | |||
| // draft-wright-json-schema-00 <<-- might be incorrect now that 2020-12 is used | |||
src/nlohmann/json-schema.hpp
Outdated
| @@ -128,7 +128,7 @@ class JSON_SCHEMA_VALIDATOR_API json_uri | |||
| namespace json_schema | |||
| { | |||
|
|
|||
| extern json draft7_schema_builtin; | |||
| extern json draft_2020_12_schema_builtin; | |||
There was a problem hiding this comment.
I left this general approach here, because I suspect that the intent is to allow for multiple versions of the schema to be included simultaneously -- and validate against the one indicated by $schema. Is that correct?
If not, then this variable should be renamed to something more generic, like schema_builtin.
| "tests": [ | ||
| { | ||
| "description": "valid definition schema", | ||
| "data": { | ||
| "definitions": { | ||
| "$defs": { |
There was a problem hiding this comment.
I don't think this is correct; the test is still failing (er, passing when it should fail). Could someone help me understand the structure here better?
| @@ -15,7 +15,7 @@ | |||
| { | |||
| "description": "invalid definition schema", | |||
| "data": { | |||
| "definitions": { | |||
| "$defs": { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.