Skip to content

Conversation

@konekomind
Copy link
Contributor

@konekomind konekomind commented Dec 18, 2025

Closes #291 , #140

This is kinda a overview of what the code does https://excalidraw.com/#json=z72Pe9EIP7u8iw709O2yp,kZ-ehRANGAjs3lWvhiLBzQ
Changes to batches, locks, parent process continuation https://excalidraw.com/#json=iX94_Bk4_xORKYzrErc_d,babt027VBZ1B8EAxwp6HhQ

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @konekomind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a major feature by implementing robust support for BPMN sub-processes and multi-instance activities. It involves a deep overhaul of the process engine's internal workings, from database schema and data models to core execution logic and variable management. The changes ensure that the engine can correctly manage the lifecycle of nested processes and parallel/sequential activity repetitions, significantly expanding its capability to execute intricate BPMN diagrams.

Highlights

  • Sub-process and Multi-instance Support: Introduced comprehensive support for BPMN sub-processes and multi-instance activities, allowing for more complex process modeling and execution.
  • Flow Element Instance Tracking: Refactored the FlowElementHistory concept into FlowElementInstance, enhancing the tracking of process execution by storing detailed information including execution tokens, input variables, and output variables for each flow element.
  • Database Schema Updates: Modified the database schema to support sub-process metadata (parent process definition key, target element ID, and instance key) and the enriched FlowElementInstance data.
  • Variable Propagation Enhancements: Improved variable handling mechanisms with new methods like EvaluateAndSetMappingsToLocalVariables and PropagateLocalVariablesToParent, ensuring accurate variable flow between parent and child processes, and within multi-instance contexts.
  • Engine Core Refactoring: Undertook significant refactoring of the core engine logic, including how process instances are created, run, and how execution tokens are managed, to seamlessly integrate sub-process and multi-instance execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot]

This comment was marked as resolved.

@konekomind konekomind marked this pull request as ready for review January 27, 2026 13:13
In memory database had different query results than rq layer, will add test that test unit test with rqlite as well
@konekomind konekomind merged commit 03f2a48 into main Feb 2, 2026
4 of 5 checks passed
@konekomind konekomind deleted the feature/sub-process branch February 2, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bpmn Sub Process support

2 participants