Compile md4c into QOwnNotes #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally QOwnNotes should use the system md4c but its not possible atm.
DEV_MODE currently enables -Werror on linux
So what is the PR doing, solving or improving? Is it for #3076? Don't we need https://github.com/qownnotes/md4c? |
|
Ah, really for #3076, thank you very much! |
Just treating md4c as part of QOwnNotes source instead of linking it into QOwnNotes. This is what we do in the qmake file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally QOwnNotes should use the system md4c but its not possible atm.