#3066 fix: Check for script updates sub-button in settings dialog

Signed-off-by: Patrizio Bekerle <[email protected]>

CHANGELOG.md

@@ -6,6 +6,9 @@
   - In addition, a button to search the *Script repository* was added
 - A problem with the script settings for some users in the `Ollama AI backend integration`
   script was fixed (for [#3052](https://github.com/pbek/QOwnNotes/issues/3052))
+- The `Check for script updates` sub-button in the *Scripting settings* was fixed
+  (for [#3064](https://github.com/pbek/QOwnNotes/issues/3064))
+
 ## 24.8.0
 - In the *AI settings* there now are buttons to test the connection to the AI services
   (for [#3062](https://github.com/pbek/QOwnNotes/issues/3062))

src/dialogs/scriptrepositorydialog.cpp

@@ -21,6 +21,7 @@
 #include <QtWidgets/QMessageBox>
 #include <QtWidgets/QSplitter>
 
+#include "services/scriptingservice.h"
 #include "ui_scriptrepositorydialog.h"
 
 ScriptRepositoryDialog::ScriptRepositoryDialog(QWidget *parent, bool checkForUpdates)
@@ -467,3 +468,13 @@ void ScriptRepositoryDialog::on_searchScriptEdit_textChanged(const QString &arg1
 }
 
 Script ScriptRepositoryDialog::getLastInstalledScript() { return _lastInstalledScript; }
+
+void ScriptRepositoryDialog::checkForScriptUpdates(QWidget *parent) {
+    auto *dialog = new ScriptRepositoryDialog(parent, true);
+    dialog->searchForUpdates();
+    dialog->exec();
+    delete (dialog);
+
+    // Reload the scripting engine
+    ScriptingService::instance()->reloadEngine();
+}

src/dialogs/scriptrepositorydialog.h

@@ -24,6 +24,7 @@ class ScriptRepositoryDialog : public MasterDialog {
 
     void searchForUpdates();
     void searchForUpdatesForScripts(const QList<Script> &scripts);
+    static void checkForScriptUpdates(QWidget *parent = nullptr);
 
    signals:
     void updateFound();

src/dialogs/settingsdialog.cpp

@@ -3778,7 +3778,9 @@ void SettingsDialog::searchScriptInRepository(bool checkForUpdates) {
 /**
  * Opens a dialog to check for script updates
  */
-void SettingsDialog::checkForScriptUpdates() { searchScriptInRepository(true); }
+void SettingsDialog::checkForScriptUpdates() {
+    ScriptRepositoryDialog::checkForScriptUpdates(this);
+}
 
 /**
  * Saves the enabled state of all items and reload the current script page to

src/mainwindow.cpp

@@ -11139,13 +11139,7 @@ void MainWindow::setMenuEnabled(QMenu *menu, bool enabled) {
 }
 
 void MainWindow::on_actionCheck_for_script_updates_triggered() {
-    auto *dialog = new ScriptRepositoryDialog(this, true);
-    dialog->searchForUpdates();
-    dialog->exec();
-    delete (dialog);
-
-    // Reload the scripting engine
-    ScriptingService::instance()->reloadEngine();
+    ScriptRepositoryDialog::checkForScriptUpdates(this);
 }
 
 /**